Blocks inside embed - more clear description - #1069
Closed
mildabre wants to merge 153 commits into
Closed
Conversation
dg
force-pushed
the
master
branch
29 times, most recently
from
December 20, 2024 20:13
4c6d8aa to
edce030
Compare
Member
|
Thanks — I agree the isolation could read more clearly. Rather than adding a second paragraph (which duplicated most of the existing one), I reworded the opening sentence in both language versions in 16f3b9bee: "Blocks inside embed tags form a separate layer, isolated from the blocks outside the embed. Therefore, they can have the same name as a block outside without colliding …" The following sentence already documents the local-block exception. Closing since the branch can't be merged directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current description of isolation blocks inside {embed} from blockc outside is not very clear. I try submit more clear description.